====== Laravel Architecture & Code Review Checklist ======

===== 1. Architecture Review =====

==== System Design ====

Checklist:

  * [ ] Clear separation of concerns
  * [ ] Domain logic separated from controllers
  * [ ] Business logic not inside routes
  * [ ] Business logic not inside models
  * [ ] Reusable services implemented
  * [ ] Event-driven where appropriate
  * [ ] Scalability considered
  * [ ] Maintainability prioritized

Recommended Structure:

<code>
app/
├── Http/
│   ├── Controllers/
│   ├── Middleware/
│   └── Requests/
├── Services/
├── Repositories/
├── Jobs/
├── Events/
├── Listeners/
├── Policies/
├── DTOs/
├── Actions/
└── Exceptions/
</code>

----

===== 2. Code Organization =====

==== Controller Review ====

Checklist:

  * [ ] Thin controllers
  * [ ] Single responsibility
  * [ ] Validation delegated to FormRequest
  * [ ] Business logic moved to Service/Action
  * [ ] Consistent response format

Bad:

<code php>
public function store(Request $request)
{
    // validation
    // business logic
    // database logic
    // external api call
}
</code>

Good:

<code php>
public function store(CreateOrderRequest $request)
{
    return $this->orderService->create(
        $request->validated()
    );
}
</code>

----

===== 3. Business Logic Review =====

==== Service Layer ====

Checklist:

  * [ ] Complex business logic in Service
  * [ ] Reusable logic centralized
  * [ ] Services unit tested
  * [ ] No duplicated business logic

Example:

<code php>
OrderService
PaymentService
InventoryService
NotificationService
</code>

==== Action Pattern ====

Checklist:

  * [ ] One action = one use case
  * [ ] Easy to test
  * [ ] Easy to reuse

Example:

<code>
CreateOrderAction
CancelOrderAction
ProcessRefundAction
</code>

----

===== 4. Validation Review =====

==== Request Validation ====

Checklist:

  * [ ] FormRequest used
  * [ ] Validation rules centralized
  * [ ] Authorization handled

Good:

<code php>
class CreateOrderRequest extends FormRequest
{
    public function rules()
    {
        return [
            'email' => 'required|email'
        ];
    }
}
</code>

Bad:

<code php>
if (!$request->email) {
   ...
}
</code>

----

===== 5. Database Review =====

==== Migration Review ====

Checklist:

  * [ ] All schema changes via migration
  * [ ] No manual database changes
  * [ ] Rollback supported
  * [ ] Indexes defined
  * [ ] Foreign keys reviewed

Example:

<code php>
$table->index('email');
$table->foreignId('user_id');
</code>

==== Query Review ====

Checklist:

  * [ ] No N+1 queries
  * [ ] Eager loading used
  * [ ] Index usage verified
  * [ ] Pagination used

Bad:

<code php>
foreach ($users as $user) {
    echo $user->orders;
}
</code>

Good:

<code php>
User::with('orders')->get();
</code>

----

===== 6. Eloquent Review =====

Checklist:

  * [ ] Relationships defined properly
  * [ ] Mass assignment protected
  * [ ] Hidden fields configured
  * [ ] Casting configured
  * [ ] Accessors/Mutators used correctly

Example:

<code php>
protected $fillable = [
    'name',
    'email'
];
</code>

<code php>
protected $hidden = [
    'password'
];
</code>

----

===== 7. API Design Review =====

==== REST Standards ====

Checklist:

  * [ ] Consistent endpoints
  * [ ] Proper HTTP verbs
  * [ ] Proper status codes
  * [ ] Versioning strategy

Examples:

<code>
GET     /api/v1/orders
POST    /api/v1/orders
GET     /api/v1/orders/{id}
PUT     /api/v1/orders/{id}
DELETE  /api/v1/orders/{id}
</code>

==== API Response Format ====

Checklist:

  * [ ] Consistent structure
  * [ ] Error handling standardized

Example:

<code json>
{
  "success": true,
  "data": {}
}
</code>

Error:

<code json>
{
  "success": false,
  "message": "Validation failed"
}
</code>

----

===== 8. Security Review =====

==== Authentication ====

Checklist:

  * [ ] Authentication